django-loci
django-loci copied to clipboard
[bug] Real-time update logic does not update address field
I am not 100% sure if this is intentional or not, but I just noticed that the real-time update logic does not update address field:
https://github.com/user-attachments/assets/e542c641-28a8-4b55-bef5-13e2e3c51426
I believe that if the address field changes it would be a lot better to send this information in the update broadcasted via websocket, the UI then can decide what to do with it.
In the case of these two pages, I think we should update the address field accordingly.
We need a selenium browser test for this. The channels docs has some references on selenium testing. In the test, let's verify that both the coordinates and address are updated.
System Informatioon:
- Python Version: 3.10
- Django Version: Django 4.2.20
Updates
Passed address field data along with geometry field data (coordinates for the map) in the websocket and updated the frontend accordingly. Now the address field has also been updated on changing the geometry field in real time.
Demo:
https://github.com/user-attachments/assets/cfdc3f1f-72d4-4209-bf2d-63eb1862dc1d
Once done with issue #904 in openwisp-controller
Will add test for this