ansible-openwisp2 icon indicating copy to clipboard operation
ansible-openwisp2 copied to clipboard
verified publisher icon openwisp

[bug/qa] Fix lint errors being ignored #485

Open ssmadhavan006 opened this issue 4 weeks ago • 1 comments

Checklist

  • [x] I have read the OpenWISP Contributing Guidelines.
  • [x] I have manually tested the changes proposed in this pull request.
  • [x] I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • [ ] I have updated the documentation.

Reference to Existing Issue

Closes #485.

Description of Changes

commit - fb328699a0a6fc8081e70b08e90b8eb88058fe0f

  • Removed broken lint blocks from molecule/default/molecule.yml and molecule/local/molecule.yml
  • Edited run-qa-checks script by adding yamllint and ansible-lint
  • Add .yamllint.yml config to exclude virtual environments and and irrelevant files
  • Update CI 'ci.yml' with continue-on-error: true and added Added conditional test execution based on dependency installation success
  • Fixed indentation in molecule/resources/converge.yml
  • Removed trailing spaces in vars/debian-13.yml
  • Converted all YAML files from CRLF to LF line endings
  • Lint errors are no longer ignored, failures properly reported

commit 986f4669a68e03a2579161e172e9e489f31e75f5

  • Updated Molecule callback configuration to replace deprecated yaml stdout_callback with ansible.builtin.default and result_format: yaml, resolving CI failures due to removal of community.general.yaml removal in v12+.

Screenshot

N/A

ssmadhavan006 avatar Dec 02 '25 15:12 ssmadhavan006

Hi @nemesifier ,

Just a quick update from my side:

After my original PR (fb32869) failed due to the Molecule deprecation issue (which was unrelated to the lint fixes), I added a follow-up commit (986f466) that updates the Molecule callback configuration and resolves the CI failure. You kindly triggered the GitHub Actions run for me, and all tests passed successfully. However, a recent commit in the repository has now introduced a merge conflict. Whenever you get a moment, could you please take a look at the PR again? All CI checks were previously green with my fix, so I can rebase or update the PR as needed once you confirm. No rush just wanted to keep everything on your radar. Thanks you for your time!!!

ssmadhavan006 avatar Dec 06 '25 15:12 ssmadhavan006