peatio

peatio copied to clipboard

Use batch updates for canceling orders

1

https://github.com/rubykube/peatio/blob/d38ae99fde6aef3273176f55b51ab596cdbf4985/app/api/v2/market/orders.rb#L116 We should do something like this: `Order.where(state: 100).find_in_batches {|batch| batch.each {|o| Order.cancel(o.id)}}` Currently, it dosent delete all orders even if the user has like 50 orders. I think we...

martianatwork

I checked the API, The Trading Fee API Provides fees for all markets but theres no way to get trading fees for the current user. No API's expose the members...

martianatwork

https://github.com/rubykube/peatio/blob/26445f1aa4d714351824b54f5207276602a726a8/config/initializers/redis_store.rb#L3

mod

Issues regarding multiple ETH withdrawals and their validity with wallet balance

1

If we create 100 ETH Withdrawals, each is 1 ETH, and hotwallet has 50 ETH now we process them all while we process it, we call eth_getBalance which returns the...

krtschmr

https://github.com/rubykube/peatio/blob/master/app/services/blockchain_service.rb#L53 this should be more like `@addresses ||= PaymentAddress.where(currency: @currencies).pluck(:address).compact` in the worker we have already the service instance, so the instance only needs to load all addresses once. https://github.com/rubykube/peatio/blob/master/app/workers/daemons/blockchain.rb#L33...

krtschmr

https://github.com/rubykube/peatio/blob/master/app/services/blockchain_service.rb#L45 doesn't this need to be `update_height(block_number, block_number)`? if we have block 100, and we process it, assume it takes a while, like 10 seconds, then we call update and...

krtschmr

i don't get it. why do we ` extend Memoist ` but never call the memoize method on the `Bitcoin::Wallet`?

krtschmr