credo-ts icon indicating copy to clipboard operation
credo-ts copied to clipboard

Published 20 hours ago • verified publisher icon openwallet-foundation

feat(ledger): Add ledgerService interface

Open DaevMithran opened this issue 2 years ago • 2 comments

Signed-off-by: DaevMithran [email protected]

Question

  • instead of indyLedgers. Can we change it to ledgers : { indy: [ ], cosmos: [ ] } .etc

DaevMithran avatar Jul 29 '22 14:07 DaevMithran

Thanks for this PR @DaevMithran. Left a suggestion, as I think we can get this into 0.2.x (we would like to get it in before 0.3.0).

Also it seems the tests are failing. Could you take a look?

TimoGlastra avatar Aug 10 '22 08:08 TimoGlastra

@TimoGlastra I beleive the failing test cases are due to the previous commits. I'll create another pull request for v0.2.3 then. I'll remove the breaking change

DaevMithran avatar Aug 10 '22 12:08 DaevMithran

is there any update on this?

naonishijima avatar Oct 20 '22 06:10 naonishijima