credo-ts icon indicating copy to clipboard operation
credo-ts copied to clipboard

feat: present proof v2 json ld

Open NB-PrasadKatkar opened this issue 3 years ago • 2 comments

Worked on Present Proof V2 to work with JSON-LD credentials RFC-0510 https://github.com/hyperledger/aries-rfcs/blob/main/features/0510-dif-pres-exch-attach/README.md

  • Refactor V1 service and some methods of V2 service
  • New Service to handle presentation exchange formats
  • e2e test and unit test for Proposal and Proof Request for V2 Presentation exchange

NB-PrasadKatkar avatar May 10 '22 12:05 NB-PrasadKatkar

This is not ready yet, converting to draft

TimoGlastra avatar May 14 '22 15:05 TimoGlastra

Codecov Report

Merging #760 (463a718) into main (b5a2536) will decrease coverage by 1.32%. The diff coverage is 85.19%.

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   87.49%   86.16%   -1.33%     
==========================================
  Files         457      524      +67     
  Lines       11080    13524    +2444     
  Branches     1864     2319     +455     
==========================================
+ Hits         9694    11653    +1959     
- Misses       1324     1770     +446     
- Partials       62      101      +39     
Impacted Files Coverage Δ
packages/core/src/agent/MessageSender.ts 84.53% <ø> (ø)
packages/core/src/agent/helpers.ts 100.00% <ø> (ø)
...ges/core/src/agent/models/InboundMessageContext.ts 100.00% <ø> (ø)
.../core/src/modules/connections/ConnectionsModule.ts 67.52% <ø> (ø)
...s/formats/models/CredentialFormatServiceOptions.ts 100.00% <ø> (ø)
.../modules/credentials/services/CredentialService.ts 100.00% <ø> (ø)
packages/core/src/modules/dids/DidsModule.ts 60.00% <ø> (ø)
...ges/core/src/modules/dids/domain/key-type/index.ts 100.00% <ø> (ø)
.../src/modules/dids/domain/key-type/keyDidMapping.ts 90.90% <ø> (ø)
.../core/src/modules/dids/repository/DidRepository.ts 83.33% <ø> (ø)
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5a2536...463a718. Read the comment docs.

codecov-commenter avatar May 28 '22 15:05 codecov-commenter

This PR can be closed now: it will be superseded by a new PR for all the PPV2 (jsonld/PEX) work in due course.

NB-MikeRichardson avatar Oct 24 '22 07:10 NB-MikeRichardson