credo-ts icon indicating copy to clipboard operation
credo-ts copied to clipboard

Published 20 hours ago • verified publisher icon openwallet-foundation

Fix repolinter issues

Open TimoGlastra opened this issue 4 years ago • 7 comments

Hyperledger has some guidelines on repo structure. A report for Aries Framework JavaScript is available here:

https://github.com/ryjones/rl-report/blob/main/main/aries-framework-javascript-repolinter-report.md

We should try to fix these issues

TimoGlastra avatar Mar 31 '21 19:03 TimoGlastra

Hi @TimoGlastra , can you please explain it a bit more. I see its already there in #223

shoebsd31 avatar Apr 02 '21 19:04 shoebsd31

Sure! PR #223 adds a github action to run the report that I linked to in this issue. However it does not fix any of the errors from the report. The action allows to check this on a regular basis on ourselves.

Do you want to work on this issue? I haven't taken a good look at the report, but maybe you're able to fix some of them.

Otherwise there's always other issues to work on :-)

TimoGlastra avatar Apr 02 '21 19:04 TimoGlastra

OK i would love to try this out

shoebsd31 avatar Apr 02 '21 21:04 shoebsd31

@TimoGlastra I will need to wait for the pull-request to get merged

shoebsd31 avatar Apr 03 '21 07:04 shoebsd31

OK i would love to try this out

You got it!

@TimoGlastra I will need to wait for the pull-request to get merged

Why is that?

TimoGlastra avatar Apr 03 '21 07:04 TimoGlastra

when the pull-request is merged with the master, I will rebase the master in my fork and update the workflow file.

shoebsd31 avatar Apr 03 '21 10:04 shoebsd31

Merged!

see https://github.com/hyperledger/aries-framework-javascript/runs/2260188889?check_suite_focus=true for the first run

TimoGlastra avatar Apr 03 '21 15:04 TimoGlastra