credo-ts icon indicating copy to clipboard operation
credo-ts copied to clipboard

Switch from prettier + eslint to Biome

Open TimoGlastra opened this issue 10 months ago • 4 comments

Example of setup can be found here: https://github.com/openwallet-foundation-labs/oid4vc-ts/blob/main/biome.json

https://github.com/openwallet-foundation-labs/oid4vc-ts/blob/main/package.json#L14-L15

Things to consider:

  • migration of all ESLint rules to Biome. Some may not be needed, but e.g. no restricted globals would help: https://github.com/openwallet-foundation/credo-ts/blob/main/.eslintrc.js#L78

Wait for all big PRs that are open to be merged?

  • [ ] https://github.com/openwallet-foundation/credo-ts/pull/2127

TimoGlastra avatar Jan 16 '25 14:01 TimoGlastra

Everything that helps to improve CI performance will be well received, and certainly eslint is getting very, very slow since some time. I don't have experience with Biome but I think we could give a try.

genaris avatar Jan 27 '25 19:01 genaris

Basically all projects I start now use Biome and i strongly prefer it over prettier+eslint. It does not require 10 plugins for everything to work, it is insanely fast and way easier to configure.

I think we can introduce it with just the config some rules off. And slowly in following PRs turn each rule on with the fixes. Might be a nicer review process because of that.

berendsliedrecht avatar Jan 28 '25 10:01 berendsliedrecht

@sairanjit the big didcomm PR got merged, so feel free to take a stab at the biome setup!

TimoGlastra avatar Jan 29 '25 03:01 TimoGlastra

Sure @TimoGlastra I will pick this soon.

sairanjit avatar Jan 29 '25 04:01 sairanjit

This is done 🙌 (thanks again @sairanjit )

TimoGlastra avatar Nov 13 '25 20:11 TimoGlastra