credo-ts icon indicating copy to clipboard operation
credo-ts copied to clipboard

feat: query connections by theirLabel and alias

Open genaris opened this issue 1 year ago • 4 comments

This was mainly created to fix https://github.com/openwallet-foundation/credo-ts-ext/issues/267, as it might be useful to query connections by these parameters.

The bad thing about it is that previously created connections won't work with these query parameters, unless we do a migration script (which of course should be reserved to a major version).

genaris avatar Apr 04 '24 23:04 genaris

Any specific reason why we have not merged this?

Will this be blocked until the next major release

GHkrishna avatar Jun 20 '24 12:06 GHkrishna

⚠️ No Changeset found

Latest commit: f0ae21a6977ca9f79e4b8f3f55cb456855bc1ad5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 21 '24 13:06 changeset-bot[bot]

The reason we didn't merge it, as adding it doesn't solve it for already stored records. We can probably merge it now, and do the migration later on? However, it won't be clear from the API that these values are only queryable for new records. So maybe wait until 0.6?

TimoGlastra avatar Jun 21 '24 13:06 TimoGlastra

Okay, that seems a bit far but makes sense to add it in 0.6 :)

GHkrishna avatar Jun 25 '24 06:06 GHkrishna