Signed-off-by: ryankoch13 [email protected]

Summary of Changes

This PR removes the old management of revocation notification using the context providers and instead uses the new AFJ and react hook functionality to detect if a credential is revoked. Once a credential is revoked, a new notification will appear on the Home screen. If the credential details is viewed for the revoked credential it will add a metadata property to get rid of the notification.

It should be noted that the "CredentialRevokedMessageTitle" was edited and a new string was added to the English localization file. Please let me know if anyone has suggestions on how to avoid these changes or update the other translation files to match.

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Oct 22 '22 00:10 ryankoch13

Seems like the linter is failing. Are we referencing the correct types?

Oct 27 '22 17:10 amanji

@ryankoch13 I think you can run these tests locally and fix 'em in one swoop. Normally husky runs them on as a pre-commit hook so you can't commit unless linting and typechecking are ok. Might be broken on your dev machine. In any case, I think you can run:

npm run pre-commit-lint
npm run typecheck

or

npm run lint
npm run prettier
npm run typecheck

Nov 22 '22 20:11 jleach

@ryankoch13 I think if you just change 2 -> 3 in the 2nd failing test and update findByText('Home.Notifications (2)') to be findByText('Home.Notifications (3)') it should pass the tests.

Nov 23 '22 03:11 jleach

@ryankoch13 Feel free to do the honours and merge the PR. Thanks for your efforts on this!

Nov 26 '22 17:11 amanji

@amanji No, thank you for your patience and help getting it all cleaned up! I swear I will get my dev environment working again so I can fix these tests before I push up next time

The old PR's I did for bifold were with a different github ID so I don't have permissions to merge yet :(

Nov 26 '22 17:11 ryankoch13

Hi @ryankoch13 @amanji @jleach

After revoking a credential from agent side, We are using following attributes in Revoke APi { "comment": "string", "connection_id": "3fa85f64-5717-4562-b3fc-2c963f66afa6", "cred_ex_id": "3fa85f64-5717-4562-b3fc-2c963f66afa6", "cred_rev_id": "12345", "notify": true, "notify_version": "v1_0", "publish": true, "rev_reg_id": "WgWxqztrNooG92RXvxSTWv:4:WgWxqztrNooG92RXvxSTWv:3:CL:20:tag:CL_ACCUM:0", "thread_id": "string" } But I am not receiving any notification for revoked credential in the app. Instead I am getting the following error in the console:

Can anyone help in what I might be doing wrong?

Dec 18 '23 05:12 jainavinash845

bifold-wallet
bifold-wallet copied to clipboard

feat: use AFJ react hooks to listen for revocation

Summary of Changes

Related Issues

Pull Request Checklist

bifold-wallet bifold-wallet copied to clipboard

feat: use AFJ react hooks to listen for revocation

Summary of Changes

Related Issues

Pull Request Checklist

bifold-wallet
bifold-wallet copied to clipboard