bifold-wallet icon indicating copy to clipboard operation
bifold-wallet copied to clipboard

Added ui config file

Open ryankoch13 opened this issue 2 years ago • 1 comments

Signed-off-by: ryankoch13 [email protected]

Summary of Changes

This PR adds a new uiConfig file to the core/configs directory. By default, this PR shouldn't change the app at all. If the flags are switched though, users are able to configure the app to use 5 tabs instead of 3, navigate to the chat screen upon a connection being made instead of waiting for a notification to come through, hide the tab labels, use the QR display screen, or remove the highlight circle around the Scan tab.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • [x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • [x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • [x] Updated documentation as needed for changed code and new or modified features;
  • [x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

ryankoch13 avatar Jun 27 '22 13:06 ryankoch13

@ryankoch13 When I run the PR I still see chat enabled for contacts. Are you going to add this config option to this PR or will that be an add-on further down the road.

jleach avatar Jun 27 '22 17:06 jleach

I think this PR is stale now. Please re-open if you would like to resubmit.

jleach avatar Sep 26 '22 20:09 jleach

May be worthwhile discussing in a future Bifold UG call

JamesKEbert avatar Sep 26 '22 21:09 JamesKEbert

Happy to include the change but the last commit was Jul 19 and it needs some TLC to be merged. Rebase in main and make sure it works with recent updates.

jleach avatar Sep 26 '22 22:09 jleach