passwdqc
passwdqc copied to clipboard
openwall
passwdqc: Remove relative path
using relative paths causes issues with symlink we can install and make a symlink in the same directory "/usr/lib"
Sorry, I didn't get the scenario of SHARED_LIBDIR & DEVEL_LIBDIR, where it gonna break?
Despite, is there any specific reason for having the libpasswdqc.so.1 in /usr/lib and making a smylink libpasswdqc.so in /lib?
in my case, I maintain a toolchain directory where /usr was symlinked to the (.) current directory. In other cases like yocto buildsystem rootfilesystem can be made to use the symlink of /usr location to others. In that case, it fails. That's the reason, I made the change to have the library and its symlink in the same location.
@rprasanth This should not be merged as-is because it breaks setups when SHARED_LIBDIR != DEVEL_LIBDIR, and because it uses DEVEL_LIBDIR inconsistently with its name. We do not currently have an obviously better/proper fix. Do you?
@rprasanth I think a better fix would be to make the ln change conditional upon SHARED_LIBDIR and DEVEL_LIBDIR being the same (otherwise use our current ln invocation with relative path). Can you please implement that and force-push to this PR? Thanks!