john icon indicating copy to clipboard operation
john copied to clipboard

make's target ../run/dynacomptest is broken; also add it to CI?

Open AlekseyCherepanov opened this issue 1 year ago • 2 comments

../run/dynacomptest is not built by default and it seems outdated.

$ make ../run/dynacomptest
[...]
dynamic_compiler.c: In function ‘dynamic_assign_script_to_format’:
dynamic_compiler.c:2639:45: error: ‘options’ undeclared (first use in this function); did you mean ‘optind’?

(I found the target because it was the only user of UNICODE_NO_OPTIONS that I needed for tests in #5531. There I'll fix a problem with options used in unicode.h.)

BTW it could work on CI as other tests in make check, could not it?

AlekseyCherepanov avatar Sep 15 '24 22:09 AlekseyCherepanov

Error in my previous message is from modified Makefile.in. Normal build fails earlier:

make: *** No rule to make target 'base64.o', needed by '../run/dynacomptest'.  Stop.

AlekseyCherepanov avatar Sep 15 '24 22:09 AlekseyCherepanov

I wasn't even aware of this make target.

@AlekseyCherepanov Is this something you want to fix? If so, please give it a try. Thanks!

solardiz avatar Sep 22 '24 23:09 solardiz