training_extensions icon indicating copy to clipboard operation
training_extensions copied to clipboard

[OTE_SDK_TESTS] Added input parameters validation and tests. Part 2 Shapes

Open saltykox opened this issue 3 years ago • 9 comments

Added input parameters validations for Shapes classes of OTE SDK: • Ellipse class: initialization and get_evenly_distributed_ellipse_coordinates methods • Point class: initialization, normalize_wrt_roi and denormalize_wrt_roi_shape methods • Polygon class: initialization method • Rectangle class: initialization, is_full_box and crop_numpy_array methods • Shape class: initialization, intersects, contains_center, get_labels, append_label, set_labels and _validate_coordinates methods Tests updated according to above changes: • test_rectangle.py: test_rectangle_is_full_box Added tests/parameters_validation/test_shapes_input_parameters_validation.py with negative scenarios to check that ValueError exception is raised when unexpected type object is specified in Shape methods

Task: CVS-77259

saltykox avatar Feb 02 '22 06:02 saltykox

run ote_sdk tests

saltykox avatar Feb 02 '22 09:02 saltykox

run ote_sdk tests

saltykox avatar Feb 02 '22 14:02 saltykox

Can one of the admins verify this patch?

nervana-ff avatar Feb 15 '22 15:02 nervana-ff

draft?

Ilya-Krylov avatar Feb 17 '22 09:02 Ilya-Krylov

This pull request is in the “Draft” state due to unmerged base PR https://github.com/openvinotoolkit/training_extensions/pull/890, but the approach to check input parameters is ready for review

saltykox avatar Feb 17 '22 09:02 saltykox

ote-test/1262

saltykox avatar Mar 11 '22 06:03 saltykox

@LeonidBeynenson @Ilya-Krylov please review

saltykox avatar Apr 01 '22 07:04 saltykox

run ote_sdk tests

saltykox avatar Apr 01 '22 08:04 saltykox

run ote-test

saltykox avatar Apr 01 '22 08:04 saltykox

closed due to clean up the stale branches

yunchu avatar Nov 18 '22 01:11 yunchu