openvino_notebooks icon indicating copy to clipboard operation
openvino_notebooks copied to clipboard

add stable diffusion notebook

Open eaidova opened this issue 2 years ago • 1 comments

eaidova avatar Oct 03 '22 05:10 eaidova

@eaidova just a heads up, in order for github actions to run properly you must commit notebook with empty cell outputs (cannot be executed in commit)

ryanloney avatar Oct 10 '22 15:10 ryanloney

Hi @eaidova, @slyalin, and @AlexKoff88, in order to move forward, we really appreciate your review of this notebook. Thanks for your help.

paularamo avatar Oct 25 '22 12:10 paularamo

@AlexKoff88 @ryanloney @paularamo please share your comments or approval if no further comments.

This is been a while since last review and still no clear way forward.

andrei-kochin avatar Nov 07 '22 08:11 andrei-kochin

@ryanloney @paularamo thank you for review, could you please look one more time? I applied your comments

eaidova avatar Nov 10 '22 04:11 eaidova

@eaidova it looks like our suggested changes may have broken some of the code/markdown sections. Can you take a look: image

ryanloney avatar Nov 10 '22 15:11 ryanloney

@eaidova it looks like our suggested changes may have broken some of the code/markdown sections. Can you take a look: image

@ryanloney My understanding is correct, you confused that code is part of markdown? It is expected to be here, I replaced original model which requires special legal agreement on the community version without a proprietary license. This code block demonstrates what the user should do if he wants to use original model, it should not be executed, just can be copied to the next cell before running.

eaidova avatar Nov 10 '22 15:11 eaidova

@ryanloney incorrect note should be fixed now, looks like there is some difference between markdown representation between github and jupyterlab

eaidova avatar Nov 10 '22 16:11 eaidova