openvino icon indicating copy to clipboard operation
openvino copied to clipboard

[CPU] Introduce SubModel op and Composite node

Open EgorDuplensky opened this issue 1 year ago • 4 comments

with the idea of wrapping up (grouping) parts of the model / graph into a inner model / graph without any (almost) runtime overhead. SubModel op and Compoisite node are expected to perform no extra logic and to only execute an inner model / graph

Details:

  • The naming "Composite node and SubModel operation" are discussable. A convenient option for the Composite node would be "SubGraph", but it is taken by snippets, which seems logical as well.
  • the Composite node is not yet used by plugin
  • single layer tests are to be added later. The problem is that currently it is impossible to use cpu plugin specific transformations and operations in scope of cpu func tests.

Tickets:

  • ticket-id

EgorDuplensky avatar Jul 04 '24 21:07 EgorDuplensky

@maxnick Could you please take a look

EgorDuplensky avatar Jul 05 '24 12:07 EgorDuplensky

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Aug 10 '24 00:08 github-actions[bot]

@maxnick Could you please take a look one more time? Many changes have been done after an internal discussion, so there is no extra commit on top of the previous one, I have just overridden it.

EgorDuplensky avatar Aug 14 '24 11:08 EgorDuplensky

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Aug 29 '24 00:08 github-actions[bot]

Should we introduce functional / unit tests at this point?

maxnick avatar Sep 06 '24 14:09 maxnick

Should we introduce functional / unit tests at this point?

Please check a PR description with the reason why the tests are not added yet. Actually, this issue should be resolved if we decide to move a SubModel into internal opset, which is supposed to happen I guess, since GPU is also planning to re-use a tensor parallel logic.

EgorDuplensky avatar Sep 09 '24 15:09 EgorDuplensky