openvino icon indicating copy to clipboard operation
openvino copied to clipboard

[Python-API] Feature/add new overload for get result index

Open amkarn258 opened this issue 1 year ago • 10 comments

Details:

Added new overload for get_result_index which takes op.Result as input

Tickets:

  • 131040

Closes Issue #25119

amkarn258 avatar Jun 21 '24 12:06 amkarn258

@praasz should we leave it as part of C++ API?

akuporos avatar Jun 21 '24 13:06 akuporos

hey @amkarn258 thanks for changes, could you please take a look on linters problems?

mlukasze avatar Jun 24 '24 04:06 mlukasze

@mlukasze done, sorry about that, my bad. Didn't check python linter after last commit

amkarn258 avatar Jun 24 '24 04:06 amkarn258

@mlukasze done, sorry about that, my bad. Didn't check python linter after last commit

happens all the time, don't worry thanks for a fix, restarting a CI

mlukasze avatar Jun 24 '24 05:06 mlukasze

flake8 version was older in my local so missed this fix, should work now

amkarn258 avatar Jun 24 '24 05:06 amkarn258

build_jenkins

mlukasze avatar Jun 24 '24 05:06 mlukasze

test_binary_op, compare_ie_results_with_framework

it seems the issue is with these two tests which aren't related to this PR

amkarn258 avatar Jun 24 '24 10:06 amkarn258

@praasz should we leave it as part of C++ API?

It looks like is not required to make it in C++ API, the current API can be used in pybind to get result e.g.

model->get_result_index(result.get_default_output());

or

model->get_result_index(result.shared_from_this());

praasz avatar Jun 25 '24 09:06 praasz

Hi, is there anything more to be added in this PR?

@praasz @akuporos

amkarn258 avatar Jul 01 '24 09:07 amkarn258

build_jenkins

mlukasze avatar Jul 01 '24 09:07 mlukasze

Hi @amkarn258,

After discussion with @praasz we decided that it'd be better to have this functionality only in Python API. So please, move implementation of this method to src/bindings/python/src/pyopenvino/graph/model.cpp. Also C++ test may be removed.

akuporos avatar Jul 01 '24 15:07 akuporos

Hi @amkarn258,

After discussion with @praasz we decided that it'd be better to have this functionality only in Python API. So please, move implementation of this method to src/bindings/python/src/pyopenvino/graph/model.cpp. Also C++ test may be removed.

Done

amkarn258 avatar Jul 02 '24 00:07 amkarn258

build_jenkins

mlukasze avatar Jul 02 '24 10:07 mlukasze

build_jenkins

amkarn258 avatar Jul 02 '24 13:07 amkarn258

Hi @mlukasze ,

Can you please start the workflow again

amkarn258 avatar Jul 02 '24 13:07 amkarn258

build_jenkins

akuporos avatar Jul 02 '24 14:07 akuporos

@amkarn258

Currently we have some issues with CI. For right now please, don't merge master to your branch. I'll handle it to be merged :)

akuporos avatar Jul 02 '24 14:07 akuporos

build_jenkins

akuporos avatar Jul 02 '24 22:07 akuporos

PR has been merged, congrats @amkarn258!

mlukasze avatar Jul 03 '24 07:07 mlukasze

Thanks @mlukasze If there is any other issue do assign it to me, would like to work on it

amkarn258 avatar Jul 03 '24 15:07 amkarn258

I think you found one already ;)

mlukasze avatar Jul 04 '24 04:07 mlukasze