[Python-API] Feature/add new overload for get result index
Details:
Added new overload for get_result_index which takes op.Result as input
Tickets:
- 131040
Closes Issue #25119
@praasz should we leave it as part of C++ API?
hey @amkarn258 thanks for changes, could you please take a look on linters problems?
@mlukasze done, sorry about that, my bad. Didn't check python linter after last commit
@mlukasze done, sorry about that, my bad. Didn't check python linter after last commit
happens all the time, don't worry thanks for a fix, restarting a CI
flake8 version was older in my local so missed this fix, should work now
build_jenkins
test_binary_op, compare_ie_results_with_framework
it seems the issue is with these two tests which aren't related to this PR
@praasz should we leave it as part of C++ API?
It looks like is not required to make it in C++ API, the current API can be used in pybind to get result e.g.
model->get_result_index(result.get_default_output());
or
model->get_result_index(result.shared_from_this());
Hi, is there anything more to be added in this PR?
@praasz @akuporos
build_jenkins
Hi @amkarn258,
After discussion with @praasz we decided that it'd be better to have this functionality only in Python API.
So please, move implementation of this method to src/bindings/python/src/pyopenvino/graph/model.cpp.
Also C++ test may be removed.
Hi @amkarn258,
After discussion with @praasz we decided that it'd be better to have this functionality only in Python API. So please, move implementation of this method to
src/bindings/python/src/pyopenvino/graph/model.cpp. Also C++ test may be removed.
Done
build_jenkins
build_jenkins
Hi @mlukasze ,
Can you please start the workflow again
build_jenkins
@amkarn258
Currently we have some issues with CI. For right now please, don't merge master to your branch. I'll handle it to be merged :)
build_jenkins
PR has been merged, congrats @amkarn258!
Thanks @mlukasze If there is any other issue do assign it to me, would like to work on it
I think you found one already ;)