openvino icon indicating copy to clipboard operation
openvino copied to clipboard
verified publisher icon openvinotoolkit

[CPU] RandomUniform seed alignment

Open PiotrKrzem opened this issue 1 year ago • 2 comments

Details:

  • Added variants of Philox algorithm generators from PyTorch and Tensorflow to align generated output for the same seed
  • Added x64 kernels for Philox (Tensorflow), Mersenne (PyTorch)
  • Added tests for exactness of results
  • Spec with changes description available here: https://github.com/openvinotoolkit/openvino/pull/26142

Tickets:

  • 134606

PiotrKrzem avatar Jun 18 '24 09:06 PiotrKrzem

@a-sidorova Please review the PR

dmitry-gorokhov avatar Jul 09 '24 08:07 dmitry-gorokhov

@nshchego May I ask you to carry on the review as an author of this implementation? Thank you in advance!

a-sidorova avatar Sep 11 '24 08:09 a-sidorova

@nshchego PR ready to next round of review, please take a look

mlukasze avatar Oct 30 '24 05:10 mlukasze

@a-sidorova & @nshchego CI is GREEN! and we would like to ask for next round of review

mlukasze avatar Nov 13 '24 05:11 mlukasze

@PiotrKrzem We just enabled clang-format for CPU Plugin: https://github.com/openvinotoolkit/openvino/pull/27944. Please rebase you PR to resolve the conflicts.

dmitry-gorokhov avatar Dec 12 '24 06:12 dmitry-gorokhov