[Good First Issue]: Extend `PrePostProcessor` module with `Clamp`
Context
Some models require preprocessing done to the data before inference. Usually it's done with packages like numpy or pillow for images, but it adds dependencies and additional steps to the inference pipeline, not to mention that these steps may not be properly performant.
PrePostProcessor module allows users to define such preprocessing steps (also postprocessing if you need it), and then embed it into the graph. It not only fixes the issues mentioned above, but also allows OpenVINO graph transformations and performance improvements to take place, increasing overall inference performance.
Lately there has been a request for a new PrePostProcessor operation - Clamp: https://github.com/openvinotoolkit/openvino/issues/23001. The issue contains information relevant to the task, it's recommended to read it.
What needs to be done?
- Modify https://github.com/openvinotoolkit/openvino/blob/master/src/core/src/preprocess/pre_post_process.cpp to include
Clampoperation. It should most likely be placed inPreProcessStepssection at https://github.com/openvinotoolkit/openvino/blob/master/src/core/src/preprocess/pre_post_process.cpp#L257. - Add the implementation to https://github.com/openvinotoolkit/openvino/blob/master/src/core/src/preprocess/preprocess_steps_impl.cpp
The implementation is preferred to use existing OpenVINO operators - in this case we have a perfect operator for that: https://docs.openvino.ai/2024/documentation/openvino-ir-format/operation-sets/operation-specs/activation/clamp-1.html 3. Add tests to https://github.com/openvinotoolkit/openvino/blob/master/src/core/tests/preprocess.cpp
Example Pull Requests
Resources
- Contribution guide - start here!
- Intel DevHub Discord channel - engage in discussions, ask questions and talk to OpenVINO developers
- How to link your Pull Request to an issue
- PrePostProcessor docs
Contact points
@p-wysocki
Ticket
N/A
I would like to work on this issue. Could you please assign this to me?
The task is yours @amansharma612, have fun :)
any updates @amansharma612?
Hey, @mlukasze been AFK for quite some time due to some work, thanks for reminding. I'll get working on this now and give you updates soon.
awesome, thank you!
If this task is not done yet, may I take the lead??
Yes you can
I did some changes in the code and while i was testing , i downloaded openvino toolkit and cmake and build whole code using it. But I am not able to run the preprocess file. Could you help me with that as this is my first contribution to open source and I am eager to learn it.
Can you please check my pull request some of the cases are passed and some of them are failed. I don't know what these cases exactly mean.
this one, right? https://github.com/openvinotoolkit/openvino/pull/26240
yess
If this task is open, I would like to work on it.
it's yours now, @vatsalashanubhag :)
Hi, please help me enable all CI checks for the Pull Request: https://github.com/openvinotoolkit/openvino/pull/27973