openvino
openvino copied to clipboard
[CORE] Test opset1::Concat shape inference with op reuse
@jane-intel could check if anything from ticket CVS-94507 is missing. I think current shape inference works correctly and recalculate concatenation axis on each use. Added test to verify it.
@praasz the problem was about this: https://github.com/openvinotoolkit/openvino/blob/master/src/core/src/op/concat.cpp#L45 https://github.com/openvinotoolkit/openvino/blob/master/src/core/include/openvino/op/concat.hpp#L43 https://github.com/openvinotoolkit/openvino/blob/master/src/core/include/openvino/op/concat.hpp#L60:L63
We probably need to remove the normalized axis from the node and return the newly normalized axis on each call of get_concatenation_axis set_concatenation_axis to be deleted
Alternatively, we could delete get and set concatenation_axis entirely (after deprecation). The project uses it only 14 times.
@praasz the problem was about this: https://github.com/openvinotoolkit/openvino/blob/master/src/core/src/op/concat.cpp#L45 https://github.com/openvinotoolkit/openvino/blob/master/src/core/include/openvino/op/concat.hpp#L43 https://github.com/openvinotoolkit/openvino/blob/master/src/core/include/openvino/op/concat.hpp#L60:L63 ...
Sure we can review if setter/getter could be marked as deprecated, I assume deprecation message should be like removed in 2025.0?
The use of this concat axis could be reduced as ov::Shape
and ov::PartialShape
support negative index to get dimensions.