[Good First Issue]: Support aten::rot90 for pytorch models

[mvafin]

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

Please refer to decomposition of this operation in torch for hints how to implement with OpenVINO opset: https://github.com/pytorch/pytorch/blob/3f89f565bb17bcb70cb6938540af0cd154c8344a/torch/_refs/init.py#L3796

What needs to be done?

• Implement conversion rule and/or transformation to support the new operation.
• Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

• torch.rot90 description
• Contribution guide - start here!
• What is OpenVINO?
• OpenVINO PyTorch Frontend
• Blog post on contributing to OpenVINO
• User documentation

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

CVS-138770

[NavyaLingisetty]

.take

[github-actions[bot]]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[p-wysocki]

Hello @NavyaLingisetty, are you still working on that issue? Do you need any help?

[parthrastogicoder]

@p-wysocki Can I help In this if it is not fixed ?

[NavyaLingisetty]

@p-wysocki Can I help In this if it is not fixed ?

Sure.

[shivamgcodes]

.take

[github-actions[bot]]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[mlukasze]

hey @shivamgcodes - do you need any support or you don't have to finish this task?

[shivamgcodes]

yea , i was stuck in a couple places .. i got the help i needed in the discord group. will make sure to submit a pr within the next 3 days sorry for the delay

[shivamgcodes]

sorry, i just could not solve it.

[mlukasze]

do not worry :) we do have plenty other tasks to pick up, maybe some other will be more convinient for you?

[shivamgcodes]

yea, i will take a look at the repository and search for more suitable issues. Thanks.

[Po-V]

.take

[github-actions[bot]]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[Po-V]

Hi, it appears flip.hpp is not available at openvino/src/core/include/openvino/op. I am not sure how to include the flip operation into my rotation without the header file ?

[eaidova]

@Po-V what do you mean under flip.hpp? Do you speak about https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/op/flip.cpp ?

There is no header inside openvino/op as pytorch flip operation implemented as decomposition of several opset operations. For reusing its functionality (as usually operation translators include own logic for input arguments validation that may be different from your operation expected) you can move common part into https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/utils.cpp and include it in https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/utils.hpp

[Po-V]

Ok, thank you @eaidova . I will try adding it to utils

[geeky33]

@p-wysocki sir is this issue solved and ready to merge or can I try on this since i have worked with the -#28395 pretty recently. and the issue here is somewhere for pytorch models which I have been trying to learn through your issues

Please let me know :)

Thanks and Regards.

[p-wysocki]

Hello @geeky33, I see that @Po-V is working hard on that issue, but there are plenty other operators to pick from for PyTorch Frontend - add a comment in https://github.com/openvinotoolkit/openvino/issues/28584 picking an operator you'd like to enable. :)

[geeky33]

@p-wysocki Right sir, I completely understand :) Looking forward for more collaborations! :) Thank you for the idea !!! Please let me know where all I can contribute in!

[esty-gitt]

.take

[Vishwa2684]

.take

[anishkr02]

.take

[Vishwa2684]

Hello @mvafin / @PiotrKrzem sir, I made a PR on this issue

#33177

Could you review it?