openvino icon indicating copy to clipboard operation
openvino copied to clipboard

[Good First Issue]: Support aten::rrelu and aten::rrelu_ for pytorch models

Open mvafin opened this issue 1 year ago • 19 comments

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

This is a randomized operation, but it is randomized only when training, for OpenVINO we assume that models are in inference only mode, so randomization is not needed. Due to that this op is actually similar to torch.nn.LeakyReLU

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

CVS-136484

mvafin avatar Mar 28 '24 11:03 mvafin

.take

Increshi avatar Mar 28 '24 13:03 Increshi

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

github-actions[bot] avatar Mar 28 '24 13:03 github-actions[bot]

@mvafin Do I need to implement two ops rrelu and rrelu_ ? If yes What is the difference between both functions in implementation ?

Increshi avatar Mar 29 '24 06:03 Increshi

@mvafin Could you please take a look at the above pull request? Happy to make changes if suggested.

Increshi avatar Mar 30 '24 03:03 Increshi

.take

TRIGON69 avatar Aug 10 '24 14:08 TRIGON69

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

github-actions[bot] avatar Aug 10 '24 14:08 github-actions[bot]

hey @TRIGON69 any help needed?

mlukasze avatar Sep 18 '24 05:09 mlukasze

.take

Hello! Looking to get started with OpenVINO. If this issue is still available, I'll be glad to put my name on it.

AdamPSU avatar Nov 08 '24 04:11 AdamPSU

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

github-actions[bot] avatar Nov 08 '24 04:11 github-actions[bot]

.take

AdamPSU avatar Nov 22 '24 11:11 AdamPSU

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

github-actions[bot] avatar Nov 22 '24 11:11 github-actions[bot]

I'm unassigning the task due to assignee's inactivity.

p-wysocki avatar Mar 05 '25 12:03 p-wysocki

.take

Jyc323 avatar Mar 05 '25 18:03 Jyc323

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

github-actions[bot] avatar Mar 05 '25 18:03 github-actions[bot]

@mvafin could you please review the above PR request and share any suggestions? I followed the tutorial https://github.com/openvinotoolkit/openvino/blob/master/docs/dev/index.md to build openvino to test my local changes. However, after multiple attempts, the pytest failed with the following error:

E       openvino._pyopenvino.OpConversionFailure: Check 'is_conversion_successful' failed at src\frontends\pytorch\src\frontend.cpp:174:
E       FrontEnd API failed with OpConversionFailure:
E       Model wasn't fully converted. Failed operations detailed log:
E       -- prim::Constant with a message:
E       None constant cannot be converted to OpenVINO opset and should be removed by consuming operation.
E       Summary:
E       -- No conversion rule found for operations: aten::rrelu
E       -- Conversion is failed for: prim::Constant

could you also help me with it? Thanks a lot!

Jyc323 avatar Mar 08 '25 19:03 Jyc323

Can i work on this issue?

Vishwa2684 avatar Nov 17 '25 06:11 Vishwa2684

.take

aorko01 avatar Dec 09 '25 04:12 aorko01

I would like to work on this issue

aorko01 avatar Dec 09 '25 04:12 aorko01

.take

Vishwa2684 avatar Dec 11 '25 06:12 Vishwa2684