[Good First Issue]: Support aten::rrelu and aten::rrelu_ for pytorch models
Context
OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.
This is a randomized operation, but it is randomized only when training, for OpenVINO we assume that models are in inference only mode, so randomization is not needed. Due to that this op is actually similar to torch.nn.LeakyReLU
What needs to be done?
- Implement conversion rule and/or transformation to support the new operation.
- Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases
Example Pull Requests
#18998
Resources
- torch.nn.RReLU description
- Contribution guide - start here!
- What is OpenVINO?
- OpenVINO PyTorch Frontend
- Blog post on contributing to OpenVINO
- User documentation
Contact points
@openvinotoolkit/openvino-pytorch-frontend-maintainers
Ticket
CVS-136484
.take
Thank you for looking into this issue! Please let us know if you have any questions or require any help.
@mvafin Do I need to implement two ops rrelu and rrelu_ ? If yes What is the difference between both functions in implementation ?
@mvafin Could you please take a look at the above pull request? Happy to make changes if suggested.
.take
Thank you for looking into this issue! Please let us know if you have any questions or require any help.
hey @TRIGON69 any help needed?
.take
Hello! Looking to get started with OpenVINO. If this issue is still available, I'll be glad to put my name on it.
Thank you for looking into this issue! Please let us know if you have any questions or require any help.
.take
Thank you for looking into this issue! Please let us know if you have any questions or require any help.
I'm unassigning the task due to assignee's inactivity.
.take
Thank you for looking into this issue! Please let us know if you have any questions or require any help.
@mvafin could you please review the above PR request and share any suggestions? I followed the tutorial https://github.com/openvinotoolkit/openvino/blob/master/docs/dev/index.md to build openvino to test my local changes. However, after multiple attempts, the pytest failed with the following error:
E openvino._pyopenvino.OpConversionFailure: Check 'is_conversion_successful' failed at src\frontends\pytorch\src\frontend.cpp:174:
E FrontEnd API failed with OpConversionFailure:
E Model wasn't fully converted. Failed operations detailed log:
E -- prim::Constant with a message:
E None constant cannot be converted to OpenVINO opset and should be removed by consuming operation.
E Summary:
E -- No conversion rule found for operations: aten::rrelu
E -- Conversion is failed for: prim::Constant
could you also help me with it? Thanks a lot!
Can i work on this issue?
.take
I would like to work on this issue
.take