openvino icon indicating copy to clipboard operation
openvino copied to clipboard
verified publisher icon openvinotoolkit

[Bug]: ov::serialize(model) does not report when file writing fails

Open mishra-18 opened this issue 1 year ago • 5 comments

Details:

  • std::ofstream doesn't throw any exceptions by default. Added bin_file.exceptions and xml_file.exceptions to resolve it
  • file_path: openvino/src/core/src/pass/serialize.cpp

Tickets:

  • Closes https://github.com/openvinotoolkit/openvino/issues/23190
  • CVS-128429

mishra-18 avatar Mar 05 '24 15:03 mishra-18

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Apr 04 '24 00:04 github-actions[bot]

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Apr 26 '24 00:04 github-actions[bot]

build_jenkins

mlukasze avatar Apr 26 '24 05:04 mlukasze

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar May 11 '24 00:05 github-actions[bot]

This PR was closed because it has been stalled for 2 week with no activity.

github-actions[bot] avatar May 18 '24 00:05 github-actions[bot]

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Jun 05 '24 00:06 github-actions[bot]

hey @mishra-18 will you find a time to finish this PR, or you are occupied somewhere else?

mlukasze avatar Jun 05 '24 04:06 mlukasze

Hey @mlukasze, I'm super busy right now, I've made the commits suggested by @t-jankowski. you can check them out!

mishra-18 avatar Jun 08 '24 04:06 mishra-18

we are looking into it, thanks!

mlukasze avatar Jun 10 '24 05:06 mlukasze

hey @mishra-18 could you please fix clang-format issue?

mlukasze avatar Jun 10 '24 07:06 mlukasze

I have made a few format changes, that should do, but the clang-format may still persist because the GitHub Token used in GitHub actions in a forked repo usually has limited permissions.

mishra-18 avatar Jun 11 '24 14:06 mishra-18

build_jenkins

mlukasze avatar Jun 18 '24 09:06 mlukasze

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Jul 06 '24 00:07 github-actions[bot]

hey @mishra-18 PR has been accepted, please fix clang and conflicts to run CIs for it

mlukasze avatar Jul 08 '24 04:07 mlukasze

hey @mlukasze, I believe the conflict is resolved, and the clang-format issue doesn't seem to persist anymore. You can check it out!

mishra-18 avatar Jul 08 '24 11:07 mishra-18

build_jenkins

mlukasze avatar Jul 25 '24 05:07 mlukasze

build_jenkins

mlukasze avatar Jul 29 '24 05:07 mlukasze

@mishra-18 please update code to pass CI

p-durandin avatar Aug 07 '24 09:08 p-durandin

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Aug 22 '24 00:08 github-actions[bot]

This PR was closed because it has been stalled for 2 week with no activity.

github-actions[bot] avatar Aug 29 '24 00:08 github-actions[bot]

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Sep 17 '24 00:09 github-actions[bot]

build_jenkins

mlukasze avatar Sep 17 '24 04:09 mlukasze

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Oct 03 '24 00:10 github-actions[bot]

@mishra-18 please solve conflicts, then we will run test suite again

mlukasze avatar Oct 03 '24 04:10 mlukasze