openvino
openvino copied to clipboard
openvinotoolkit
[BATCH] support ov::enable_profiling
Details:
To complete task-I added PERF_COUNT to the plugin.cpp And To complete the task-2 I have added get_property_params()
Tickets:
#23075, CVS-130236
Hello @zhaixuejun1993 @rkazants I am eager to join GSOC-2024 with OpenVINO and plan to submit a proposal for one of the project ideas. I have already begun exploring the codebase of OpenVINO, and I'm actively working on addressing other issues. I would appreciate guidance on any additional steps I should take.
Additionally, I'm curious if you could review my pull request.
@himanshugupta11002 thanks for this. Some thing need to do more.
- num_stream no need.
- pls also add set property test for perf_count, such as: [ADD] set_property_params{{{ov::enable_profiling(true)}}, false}, in https://github.com/openvinotoolkit/openvino/blob/f5259bd61499a35f9af80287ecf78a2c023f429a/src/plugins/auto_batch/tests/unit/plugin_set_property_test.cpp#L63
- to make the get property for pref_count pass (which didn't set by default), u need mock the get method, such as: [ADD method] ON_CALL(*m_plugin, get_property(StrEq("PERF_COUNT"), _)) .WillByDefault(Return(true)); at here https://github.com/openvinotoolkit/openvino/blob/f5259bd61499a35f9af80287ecf78a2c023f429a/src/plugins/auto_batch/tests/unit/plugin_get_property_test.cpp#L40
Pls fix the format issue @himanshugupta11002
Okay , I'll do that
@himanshugupta11002 could you please not force push the commit to avoid overwriting the original commits and comments? The latest commit has introduced more issues.
@himanshugupta11002 could you please not force push the commit to avoid overwriting the original commits and comments? The latest commit has introduced more issues.
Sorry for that, actually I accidentally discarded the updates in my master branch that closed this PR. Therefore, I reopened this PR with the previous changes. As this latest commit has more issues can you guide me how to solve them.
@himanshugupta11002 could you please not force push the commit to avoid overwriting the original commits and comments? The latest commit has introduced more issues.
I accidentally discarded the updates in my master branch that closed this PR. Therefore, I reopened this PR with the previous changes. As this latest commit has more issues can you guide me how to solve them.
Maybe you can rebase to latest master branch and clean up unnecessary code, because I saw some old code garbage in your commit, such as 2023 and dimension_tracker which have been removed in master branch.
