openvino icon indicating copy to clipboard operation
openvino copied to clipboard

[Snippets] Added dynamism support to lowered passes

Open a-sidorova opened this issue 1 year ago • 4 comments

Details:

  • Added dynamism support to lowered passes
  • Brgemm related passes aren't affected (will be updated in the corresponding tasks to dynamic brgemm support)

Tickets:

  • 123272

Prerequisites:

  • https://github.com/openvinotoolkit/openvino/pull/21934
  • https://github.com/openvinotoolkit/openvino/pull/21881

a-sidorova avatar Dec 28 '23 08:12 a-sidorova

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Jan 23 '24 00:01 github-actions[bot]

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Feb 08 '24 00:02 github-actions[bot]

@v-Golubev @IvanNovoselov guys, take a look please. You may review only last commit 849fba8

a-sidorova avatar Feb 08 '24 12:02 a-sidorova

@IvanNovoselov @v-Golubev guys, thanks for the first review!

Let me invite you to the next review step 😃

I've added Validate pass to the final stage of control flow pipeline. It'd be great if you suggest additional checks to this pass!

a-sidorova avatar Feb 22 '24 08:02 a-sidorova

Do you think we need a validation for this PR?

The PR contains specific conditions for dynamic case that cannot be validated at the moment. However, it affects the previous static pipeline. To be sure that the PR doesn't broke something, I've launched performance validation. The information (what is the commit, job) is attached in the ticket. I will ping you when the report is ready. Thanks!

a-sidorova avatar Mar 11 '24 10:03 a-sidorova

@IvanNovoselov the validation has been passes. The results are attached to the ticket: no performance regressions.

a-sidorova avatar Mar 12 '24 05:03 a-sidorova