openvino
openvino copied to clipboard
[Good First Issue]: Align behavior of ONNX Frontend function ReduceLogSum-11, 13, 18 with original framework
Context
Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX. OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models. This task requires alignment between OpenVINO ONNX Frontend and original framework implementations of ReduceLogSum for next list of opsets: opset 11, opset 13, opset 18 Necessary help will be provided by ONNX Fronted team.
What needs to be done?
Operator details can be found in ONNX Operators More details can be found in ONNX Changelog: opset 11, opset 13, opset 18
- Function already has a common implementation in OpenVINO. First of all, you need to review a documentation and prepare a table with differences between versions. It could be, for instance, a missing property, extended/reduced coverage of existing property, etc...
- Copy existing implementation here to make it aligned with original framework (extend or reduce coverage of a common implementation). Copy of modified implementation should be in a defined opset, or in opset 1 in case it implements oldest implementation. Example of multi-opset operation.
- Register the function in ops_bridge.cpp while keeping alphabetical order
- Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
- Add tests covering all use cases here
- Check Python xfailed tests to find a test marked as a xfailed for added functionality. If any exist - remove corresponding lines and try to verify by using cmdline "python -m pytest -k name_of_test". More details in adding operators to ONNX Frontend guide
Example Pull Requests
No response
Resources
- Contribution guide - start here!
- Intel DevHub Discord channel - engage in discussions, ask questions and talk to OpenVINO developers
- What is OpenVINO?
- User documentation
- Guides on ONNX Frontend architecture and ONNX Frontend tests are also available
- You can also see a blog post on contributing to OpenVINO
Contact points
@gkrivor
Ticket
No response
Hi! I'm a first time contributor. Could this issue be assigned to me?
It's yours now :)
Hello @Hunter-bitbit, do you need any help from us? :)
Hi @p-wysocki, some help would be great, yes. I'm mostly just having issues with understanding what needs to be done. I made the table of differences between versions, but steps 2 and 3 don't make much sense to me. I found the existing implementation but I don't know where to copy it to? For the registration I found a ReducedLogSum in there... do I have to specify the namespace it's in? I'm just very confused as to what I actually have to do since it seems like everything is already implemented... sorry for the hassle :\
Hello @Hunter-bitbit, it may be the case that the operator is currently correctly aligned. Could you please give a brief summary of the changes between op versions and what OpenVINO has? That would simplify the discussion a lot. cc @gkrivor
.take
Thank you for looking into this issue! Please let us know if you have any questions or require any help.
Hi, The PR is created: 23522