openvino icon indicating copy to clipboard operation
openvino copied to clipboard

[Bug] openvino does not work with other shells besides bash

Open Thodoris1999 opened this issue 1 year ago • 2 comments

Detailed description

setupvars.sh as well as other shell scripts in this repository require the information of the location of the running script, which is unfortunately famously not posix standardized and each shell implementation provides its own workaround. This repository uses bash's workaround (BASH_SOURCE[0]), which silently does not work for any other shell implementation.

Solutions
  • Create a complex function that gets the source path for each shell implementation
  • Provide multiple setup scripts, e.g. setupvars.bash and setupvars.zsh (ROS approach)
  • Use a user set environment variable (OPENVINO_HOME) and default to default path/symlink (/opt/intel/openvino), failing if it doesn't exist (nvidia approach)
Steps to reproduce

Execute any of openvino's scripts with a non bash shell

Thodoris1999 avatar May 06 '23 08:05 Thodoris1999

Ref. 111482

avitial avatar May 19 '23 17:05 avitial

This issue will be closed in a week because of 9 months of no activity.

github-actions[bot] avatar Feb 18 '24 00:02 github-actions[bot]

Hi, should this issue be a GFI? Is it agreed that it should be done and is it a good fit for new contributors? @artanokhov

p-wysocki avatar May 06 '24 08:05 p-wysocki

I'd take a look at this issue if it is decided which of the 3 options is best

Thodoris1999 avatar May 20 '24 09:05 Thodoris1999

I would keep a single script..

ilya-lavrenov avatar May 20 '24 09:05 ilya-lavrenov