openvino icon indicating copy to clipboard operation
openvino copied to clipboard

Add conv per-tensor input zero point.

Open luweizhou2016 opened this issue 3 years ago • 7 comments
trafficstars

Details:

  • Enable per-tensor zp on AVX512_VNNI and AVX512_AMX ISA to use BRGCONV kernel.
  • Merge the @luo-cheng2021 fix PR https://github.com/openvinotoolkit/openvino/pull/12877
  • Merge optimization of convolution attribute PR to lower down the load network time latency.https://github.com/openvinotoolkit/openvino/pull/12898
  • Only enable conv/group conv S8 input on AMX. Non-AMX same with 2022.1 LPT input precision config.

Tickets:

  • 88228, 91221,91868

luweizhou2016 avatar Jul 24 '22 14:07 luweizhou2016

@EgorDuplensky may I ask you to review the PR?

dmitry-gorokhov avatar Aug 03 '22 06:08 dmitry-gorokhov

@luweizhou2016 Could you please also write some description in PR message

EgorDuplensky avatar Aug 03 '22 12:08 EgorDuplensky

@EgorDuplensky Review comments applied. Thx!

luweizhou2016 avatar Aug 05 '22 00:08 luweizhou2016

@EgorDuplensky ,Updated.

luweizhou2016 avatar Aug 16 '22 00:08 luweizhou2016

The current code inclue:

  1. Enable per-tensor zp on AVX512_VNNI and AVX512_AMX ISA to use BRGCONV kernel.
  2. Merge the @luo-cheng2021 fix PR https://github.com/openvinotoolkit/openvino/pull/12877
  3. Merge optimization of convolution attribute PR to lower down the load network time latency.https://github.com/openvinotoolkit/openvino/pull/12898
  4. Only enable conv/group conv S8 input on AMX. Non-AMX same with 2022.1 LPT input precision config.

luweizhou2016 avatar Sep 16 '22 07:09 luweizhou2016

@EgorDuplensky , could you please take a look once again since the PR incorporated a couple of other ones?

maxnick avatar Sep 19 '22 07:09 maxnick

@EgorDuplensky , Review comments applied. Pls help to review. Thx!

luweizhou2016 avatar Sep 22 '22 23:09 luweizhou2016

Thx @EgorDuplensky @maxnick . Applied reveiw comments and pls review @maxnick .

luweizhou2016 avatar Sep 27 '22 07:09 luweizhou2016

Thx! Applied review comments.

luweizhou2016 avatar Sep 29 '22 00:09 luweizhou2016

@dmitry-gorokhov, could you please take a look?

maxnick avatar Sep 29 '22 07:09 maxnick

Updated. Thx! @dmitry-gorokhov

luweizhou2016 avatar Oct 08 '22 02:10 luweizhou2016