oneDNN icon indicating copy to clipboard operation
oneDNN copied to clipboard

Fix simd uni instructions for sse41

Open lohika-denis-kotov opened this issue 3 years ago • 4 comments

Description

This PR is fixing issues with sse41 for uni_* operations. Consider the following example:

uni_vsubps(xmm_y0, xmm_pred_ctr_y, xmm_y0);

, where xmm_y0 = xmm0, xmm_pred_ctr_y = xmm8 Previously this example was converted on sse41 in wrong logical instructions:

movups(xmm0, xmm8);
addps(xmm0, xmm0);

As you can see, last instruction is logically wrong addps(xmm0, xmm0);

openvino PR: https://github.com/openvinotoolkit/openvino/pull/13472

lohika-denis-kotov avatar Sep 27 '22 14:09 lohika-denis-kotov

@ceciliapeng2011 @dmitry-gorokhov @maxnick Please, take a look or assign reviewers

lohika-denis-kotov avatar Sep 27 '22 14:09 lohika-denis-kotov

@dmitry-gorokhov, could you please take a look?

maxnick avatar Oct 13 '22 09:10 maxnick

@dmitry-gorokhov @nshchego @chenhu-wang Do you have some comments for this PR ?

lohika-denis-kotov avatar Oct 14 '22 16:10 lohika-denis-kotov

@dmitry-gorokhov @nshchego @chenhu-wang Do you have additional comments ?

lohika-denis-kotov avatar Oct 19 '22 07:10 lohika-denis-kotov