nncf icon indicating copy to clipboard operation
nncf copied to clipboard

[TorchFX][Optimization] Run eliminate dead code once for constant correction commands

Open daniil-lyakhov opened this issue 5 months ago • 0 comments

🚀 Feature request

https://github.com/openvinotoolkit/nncf/pull/2882/files#r1735077003

  • Look like eliminate_dead_code should be run ones after apply all bias_update transormation. Or maybe will be better to use something like self.erase_node(old_constant_node) to remove only old constant node to avoid loops for all nodes. As i understand eliminate_dead_code here removes only old constant node. And it's actual for all usage eliminate_dead_code in transformation.py.

  • We can do it, but we should give up on transformations and move to commands for that. Leaf insertion transformation not expecting eliminate_dead_code call yet model transformer could not split bias correction and leaf insertion commands apart

Feature Use Case

No response

Are you going to submit a PR?

  • [ ] Yes I'd like to help by submitting a PR!

daniil-lyakhov avatar Aug 29 '24 09:08 daniil-lyakhov