nncf icon indicating copy to clipboard operation
nncf copied to clipboard

[Good First Issue] [NNCF] Make NNCF common accuracy aware training code pass mypy checks

Open vshampor opened this issue 1 year ago • 7 comments

This is exactly like https://github.com/openvinotoolkit/nncf/issues/2495 (see the description and tasks there), but the target code path for this one is nncf/common/accuracy_aware_training instead of nncf/common/graph.

vshampor avatar Jan 24 '24 16:01 vshampor

.take

siddhant-0707 avatar Jan 24 '24 17:01 siddhant-0707

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

github-actions[bot] avatar Jan 24 '24 17:01 github-actions[bot]

@vshampor missed this!! will wait for the next one!! thanks for informing!!

tvilight4 avatar Jan 25 '24 13:01 tvilight4

@tvilight4 I have created openvinotoolkit/nncf#2491 now, take a look.

vshampor avatar Jan 25 '24 15:01 vshampor

@vshampor thanks!! got assinged for it. will start working on the same

tvilight4 avatar Jan 25 '24 17:01 tvilight4

Hello @tvilight4, are you still working on that issue or can we reassign it?

p-wysocki avatar Feb 19 '24 14:02 p-wysocki

@vshampor could you please either link the PR to the development section of the issue or grant me some permissions in NNCF repo to do this myself?

image

I'd prefer the latter since I'm keeping an eye on all GFIs weekly.

p-wysocki avatar Mar 12 '24 09:03 p-wysocki

@p-wysocki Is this issue being actively worked on? If not, I'm down to work on it!

anzr299 avatar Apr 09 '24 10:04 anzr299

Hi @anzr299, sure! The thing is this issue is in NNCF repository and I do not have correct access rights to assign you. @vshampor could you please do it?

For now let's agree the task is yours, feel free to start working on it and ask questions. We'll figure out the formalities in the background. :)

p-wysocki avatar Apr 09 '24 11:04 p-wysocki

Sure, thank you very much! I have already started working on it.

anzr299 avatar Apr 09 '24 11:04 anzr299

Hi @p-wysocki, what is the update regarding the assignment? I was off for some time due to my dissertation submission. I am resuming work on this issue now.

anzr299 avatar Apr 15 '24 12:04 anzr299

Done, please let us know if you have any questions @anzr299. :)

p-wysocki avatar Apr 15 '24 15:04 p-wysocki

Sure, I am following the current types that are mentioned in some files. For arguments with kwargs and args, I am planning on using "...", is that fine?

anzr299 avatar Apr 15 '24 15:04 anzr299

I found some good tips here, I think you can pick one you'd like to use and it's going to be fine - worst case scenario we'll change it.

p-wysocki avatar Apr 15 '24 15:04 p-wysocki

Also, I was wondering if the the | method would be preferred over the Optional() method to denote an option between type and None since the latest updates suggest a movement towards the | direction but the current NNCF code mostly uses optional().

anzr299 avatar Apr 15 '24 18:04 anzr299

I am facing a problem in the following section of training_loop.py: image Mypy is giving an error saying the CompressionScheduler doesn't contain current_sparsity_level and current_pruning_level. A similar problem exists in the _interpolate_compression_step_update method for runner.maximal_accuracy_drop.

anzr299 avatar Apr 16 '24 19:04 anzr299

@p-wysocki @vshampor I've created a PR #2637

anzr299 avatar Apr 17 '24 02:04 anzr299