anomalib icon indicating copy to clipboard operation
anomalib copied to clipboard

Upgrade torchmetrics version

Open djdameln opened this issue 2 years ago • 2 comments

Description

  • This PR restores compatibility with the latest version of the torchmetrics package, which had some breaking changes.

  • Fixes https://github.com/openvinotoolkit/anomalib/issues/750

  • Depends on https://github.com/Lightning-AI/torchmetrics/pull/1676

Changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Refactor (non-breaking change which refactors the code base)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist

  • [x] My code follows the pre-commit style and check guidelines of this project.
  • [x] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing tests pass locally with my changes
  • [ ] I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

djdameln avatar Feb 17 '23 10:02 djdameln

Blocked by: https://github.com/Lightning-AI/metrics/issues/1526

ashwinvaidya17 avatar Mar 16 '23 13:03 ashwinvaidya17

@djdameln, can we close this PR for now?

samet-akcay avatar Apr 27 '23 08:04 samet-akcay