anomalib icon indicating copy to clipboard operation
anomalib copied to clipboard

Published 20 hours ago • verified publisher icon openvinotoolkit

🚀 Allow passing model to engine constructor

Open danylo-boiko opened this issue 11 months ago • 8 comments

📝 Description

  • Addresses https://github.com/openvinotoolkit/anomalib/issues/1639

✨ Changes

Select what type of change your PR is:

  • [ ] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [ ] 🔨 Refactor (non-breaking change which refactors the code base)
  • [x] 🚀 New feature (non-breaking change which adds functionality)
  • [ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] 📚 Documentation update
  • [ ] 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • [x] 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • [x] 📚 I have made the necessary updates to the documentation (if applicable).
  • [x] 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

danylo-boiko avatar Feb 27 '24 18:02 danylo-boiko

Hi @samet-akcay. Could you please run the unit tests? If all goes well, I will update the codebase and documentation to use the new API in a few days.

danylo-boiko avatar Feb 28 '24 12:02 danylo-boiko

@danylo-boiko the tests are triggered only for non-draft PRs. You can either mark this as ready for review or run the tests locally

ashwinvaidya17 avatar Feb 28 '24 14:02 ashwinvaidya17

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Feb 28 '24 22:02 review-notebook-app[bot]

Thanks for the efforts!

Thanks a lot for your feedback. I fixed merge conflicts.

danylo-boiko avatar Feb 29 '24 09:02 danylo-boiko

@samet-akcay, @ashwinvaidya17, @djdameln, PR is ready for code review and merge. Please take a look when you have free time.

danylo-boiko avatar Feb 29 '24 09:02 danylo-boiko

@samet-akcay, @ashwinvaidya17, @djdameln, I have fixed the conflicts related to yesterday's release.

danylo-boiko avatar Mar 01 '24 10:03 danylo-boiko

Thanks for creating this PR. I've got some comments, but would also like to hear @djdameln's opinions.

Thank you for your feedback, I have made the necessary changes.

danylo-boiko avatar Mar 18 '24 15:03 danylo-boiko

@samet-akcay, could you please take a look at the changes/comments when you have some free time?

danylo-boiko avatar Apr 15 '24 07:04 danylo-boiko