anomalib icon indicating copy to clipboard operation
anomalib copied to clipboard

πŸ”¨ Add default metrics to Engine

Open samet-akcay opened this issue 1 year ago β€’ 2 comments

πŸ“ Description

  • Metric values in Engine is currently None. When Engine is used with default values, the validation step is not run since there is no metric. Due to this there is no test results. This PR adds AUROC and F1Score as the default metrics to both image and pixel level metrics.
  • πŸ› οΈ Fixes #1747

✨ Changes

Select what type of change your PR is:

  • [ ] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [x] πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • [ ] πŸš€ New feature (non-breaking change which adds functionality)
  • [ ] πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] πŸ“š Documentation update
  • [ ] πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • [ ] πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • [ ] πŸ“š I have made the necessary updates to the documentation (if applicable).
  • [ ] πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

samet-akcay avatar Feb 21 '24 14:02 samet-akcay

Check out this pull request onΒ  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

I see that some tests are failing as they directly access pixel_metric_names

ashwinvaidya17 avatar Feb 23 '24 08:02 ashwinvaidya17