anomalib icon indicating copy to clipboard operation
anomalib copied to clipboard

📚 v1 - Update `300`, `400` and `500` notebooks

Open blaz-r opened this issue 1 year ago • 12 comments

What is the motivation for this task?

  1. Notebooks in their current state are not all working with v1
  2. There is also a bug still present with OpenVINO inferencer metadata argument #1489

Describe the solution you'd like

  • [ ] Updated notebooks
  • [ ] Updated OpenVINOInferencer in notebooks

Additional context

No response

blaz-r avatar Jan 09 '24 15:01 blaz-r

@blaz-r, can you elaborate a bit? Where do you spot errors?

We are running the notebook tests when merging stuff to v1. They are supposed to work :)

samet-akcay avatar Jan 10 '24 11:01 samet-akcay

Okay. I've seen that some are updated but while checking an issue dealing with 501 I found that it wasn't. https://github.com/openvinotoolkit/anomalib/blob/v1/notebooks%2F500_use_cases%2F501_dobot%2F501a_training_a_model_with_cubes_from_a_robotic_arm.ipynb

Here there are problems with imports and OpenVINO inferencer still has metadata_path instead of metadata. It's also using a trainer which I'm not sure if it's supposed to.

blaz-r avatar Jan 10 '24 11:01 blaz-r

ah yes ofc, 501 is not part of the tests :)

https://github.com/openvinotoolkit/anomalib/blob/f67b01d8b1cb9839fe5de2c2ecb92e56e3bf8bfe/tox.ini#L46-L49

samet-akcay avatar Jan 10 '24 11:01 samet-akcay

I'd fix it in the above PR, but there is no hazelnut_toy under https://openvinotoolkit.github.io/anomalib/_downloads/3f2af1d7748194b18c2177a34c03a2c4/hazelnut_toy.zip Where is it now?

adrianboguszewski avatar Jan 26 '24 15:01 adrianboguszewski

I'd fix it in the above PR, but there is no hazelnut_toy under https://openvinotoolkit.github.io/anomalib/_downloads/3f2af1d7748194b18c2177a34c03a2c4/hazelnut_toy.zip Where is it now?

https://github.com/openvinotoolkit/anomalib/releases/download/hazelnut_toy_dataset/hazelnut_toy.zip

samet-akcay avatar Jan 26 '24 15:01 samet-akcay

Unfortunately, a new path is not enough to fix the 300 series :/ Leaving it to you guys. The 500 series has been fixed in the PR above.

adrianboguszewski avatar Jan 26 '24 16:01 adrianboguszewski

Thanks a lot for the effort!

samet-akcay avatar Jan 26 '24 16:01 samet-akcay

Hi, I would like to attempt solving the issue.

Ashutosh-Gera avatar Mar 15 '24 22:03 Ashutosh-Gera

Sure @Ashutosh-Gera, thank you.

blaz-r avatar Mar 15 '24 23:03 blaz-r

@Ashutosh-Gera are you still working on this?

blaz-r avatar May 15 '24 06:05 blaz-r

@Ashutosh-Gera are you still working on this?

Hi blaz,

I did try to resolve this issue for a week but I was unable to find any path to resolve the issue. My apologies, if I wasted your time.. I can give it another shot if you can suggest any ideas on how can I go about this.

Ashutosh-Gera avatar May 15 '24 18:05 Ashutosh-Gera

Thanks for the effort and no worries about anything, I just wanted to know if there is anything new. If you want to continue feel free to do so, but I don't have any recommendations sadly.

blaz-r avatar May 15 '24 18:05 blaz-r