libpostal icon indicating copy to clipboard operation
libpostal copied to clipboard

A missing file name "Config.h" causing FATAL ERROR

Open JatinSingh007 opened this issue 5 years ago • 2 comments

Hi!

I was checking out libpostal, and saw something that could be improved.


My country is

India


Here's how I'm using libpostal

I'm using libpostal to train on Known Uk addresses


Here's what I did

I trained for Uk Addresses here's the link "https://archive.org/download/libpostal-parser-training-data-20170304/uk_openaddresses_formatted_addresses_tagged.random.tsv.gz" System configuration : Mac 1.8 GHz Intel Core i5 , version 10.14.6 (18G95) , Memory 8 GB 1600 MHz DDR3

Here's what I got

I received no output just an error - "matrix.h:9:10: fatal error: config.h: No such file or directory" it is unable to find config.h file the whole error looks like this

#error LIBPOSTAL_DATA_DIR not defined! In file included from sparse_matrix.h:45, from averaged_perceptron.h:27, from address_parser.h:52, from address_parser_train.c:3: file_utils.h:20:16: warning: 'struct direct' declared inside parameter list will not be visible outside of this definition or declaration #define dirent direct ^~~~~~ file_utils.h:59:30: note: in expansion of macro 'dirent' bool is_relative_path(struct dirent *ent); ^~~~~~ In file included from sparse_matrix.h:46, from averaged_perceptron.h:27, from address_parser.h:52, from address_parser_train.c:3: matrix.h:9:10: fatal error: config.h: No such file or directory #include <config.h>"

Here's what I was expecting

I was expecting normal parsed results but we were unable to resolve the error as the config.h file was missing as stated above


For parsing issues, please answer "yes" or "no" to all that apply.

Yes "https://archive.org/download/libpostal-parser-training-data-20170304/uk_openaddresses_formatted_addresses_tagged.random.tsv.gz"

  • Do all the toponyms exist in OSM (city, state, region names, etc.)?

Yes

  • If the address uses a rare/uncommon format, does changing the order of the fields yield the correct result?

No

  • If the address does not contain the city, region, etc., does adding those fields to the input improve the result?

No

  • If the address contains apartment/floor/sub-building information or uncommon formatting, does removing that help? Is there any minimum form of the address that gets the right parse?

No


Here's what I think could be improved

The error is not with the data but with a missing file config.h as stated above, we used well-known data of Uk addresses but the error of missing file could not be resolved.

JatinSingh007 avatar Jun 26 '20 12:06 JatinSingh007

Isn't this just a duplicate of https://github.com/openvenues/libpostal/issues/502 which you opened 12hrs ago or am I missing something?

missinglink avatar Jun 26 '20 12:06 missinglink

Isn't this just a duplicate of #502 which you opened 12hrs ago or am I missing something?

oh sorry my mistake I guess I opened it again

JatinSingh007 avatar Jun 26 '20 12:06 JatinSingh007