open-ui icon indicating copy to clipboard operation
open-ui copied to clipboard

[Popup spec] Update close watcher logic and focusing steps algo for popup light dismissal

Open melanierichards opened this issue 2 years ago • 1 comments

#355 lands a first editor's draft of <popup> in Open UI, and is intended to be brought to various parts of the HTML spec in WHATWG.

Of the light dismissal section, @domenic's advice and additional advice was to:

  • Add something like the dialog patch to close watcher logic
  • Update the focusing steps algorithm
  • Not to add componentized "light dismissal" definitions anywhere before relevant, i.e. before there are multiple elements that would call into that behavior. That's a little different than what we had planned for Open UI, as we do think there are multiple Open UI components that we imagine will consume from a common definition (whether or not they will all be platform changes remains to be seen).

Opening this issue to track the edit as suggested. We can add a snippet to the Open UI spec as I've done here: https://open-ui.org/components/popup#html-incubation-text-user-interaction-focus-processing-model

melanierichards avatar Aug 27 '21 00:08 melanierichards

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

github-actions[bot] avatar Mar 04 '22 00:03 github-actions[bot]

Add something like the dialog patch to close watcher logic

We will make sure that close watcher gets integrated when close watcher is added to the HTML spec. I don't feel inclined to also spell out exactly how I'm going to integrate it into HTML in domenic's repo.

Update the focusing steps algorithm

Light dismiss doesn't do this king of patching for focus anymore in my HTML spec PR for popover

Not to add componentized "light dismissal" definitions anywhere before relevant, i.e. before there are multiple elements that would call into that behavior. That's a little different than what we had planned for Open UI, as we do think there are multiple Open UI components that we imagine will consume from a common definition (whether or not they will all be platform changes remains to be seen).

In my HTML spec PR, light dismissal is not an abstraction that only has one consumer - it is specifically defined only for popovers and lives in the popover section.

This issue can be closed.

josepharhar avatar Nov 30 '22 22:11 josepharhar