open-ui icon indicating copy to clipboard operation
open-ui copied to clipboard

Investigate modal/dialogue element

Open gregwhitworth opened this issue 4 years ago • 7 comments

There is an increasing desire/demand for a or component in the web platform. There is also an explainer that is geared to addressing needs presented by the Payments WG for other items using a custom . We should ensure that needs outlined by the various design systems is also covered by this solution. The cross origin needs outlined there are real but we should figure out a way to converge the needs so that webdevs aren't having to create a modal/dialogue <N> different ways with different capabilities of styling, extensibility, etc.

gregwhitworth avatar Nov 05 '19 21:11 gregwhitworth

@gregwhitworth I'd like to take a shot at writing a spec for this. I'm working on a similar issue on our end. Going to self assign.

chrisdholt avatar Mar 06 '20 21:03 chrisdholt

@chrisdholt is there any plan to keep moving forward with this. cc @melanierichards as I know she's been looking at things like this

gregwhitworth avatar Aug 12 '20 20:08 gregwhitworth

@gregwhitworth I'll pull up the branch and see if I can get something up in the next week or so. I think I primarily need to update to align with the latest spec template and update a reference for light dismiss to the issue created the other week.

chrisdholt avatar Aug 12 '20 20:08 chrisdholt

Happy to coordinate with you on this, @chrisdholt! The work I'm tracking is popups all-up, which includes dialog: #116 Currently planning on a mega-page for popups, and we can discuss as a group how to break that up if needed. AFAICT that's the first instance of nested concepts.

melanierichards avatar Aug 14 '20 01:08 melanierichards

@melanierichards would be great to sync on this! Do you want to setup some time next week to walk through what I have currently and we can refine and get a PR out?

chrisdholt avatar Aug 14 '20 01:08 chrisdholt

@melanierichards @chrisdholt ping

gregwhitworth avatar Sep 02 '20 20:09 gregwhitworth

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

github-actions[bot] avatar Mar 21 '22 00:03 github-actions[bot]

<dialog> now exists, and it has a showModal() API which shows the given dialog as modal, in the top layer. Congrats everyone!

keithamus avatar Mar 21 '24 18:03 keithamus