ucx icon indicating copy to clipboard operation
ucx copied to clipboard
verified publisher icon openucx

UCP/PROTO/TEST: Add protocol performance data strucutre

Open yosefe opened this issue 2 years ago • 3 comments

Why

Unite common code for protocol performance manipulations @ivankochin @brminich

yosefe avatar May 13 '24 10:05 yosefe

I think it can be useful to have function that sums up two perf structures (maybe make it inplace)?

ivankochin avatar May 14 '24 09:05 ivankochin

I think it can be useful to have function that sums up two perf structures (maybe make it inplace)?

Probably yes, but since this PR is quite big IMO it's better to add it later, maybe even along with using it in rndv perf

yosefe avatar May 14 '24 09:05 yosefe

@ivankochin ok to squash?

yosefe avatar May 17 '24 08:05 yosefe

/azp run UCX PR

yosefe avatar May 19 '24 13:05 yosefe

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 19 '24 13:05 azure-pipelines[bot]

@ivankochin ok to squash?

There are still several unresolved comments that I wanted to discuss. I placed question marks under them.

ivankochin avatar May 20 '24 04:05 ivankochin

@ivankochin ok to squash?

There are still several unresolved comments that I wanted to discuss. I placed question marks under them.

@ivankochin thanks, fixed

yosefe avatar May 20 '24 09:05 yosefe