ucx icon indicating copy to clipboard operation
ucx copied to clipboard

UCT/VERBS/RC: Fix the macro that is supposed fill desc within uct rc.

Open toorajtaraz opened this issue 1 year ago • 6 comments

Fix the macro that is supposed fill desc withing uct rc.

What

This change fixes a typo in the implementation of UCT_RC_VERBS_FILL_DESC_WR.

Why

The assignment to sge->addr incorrectly uses desc instead of _desc. While this won't cause a compilation error if the actual variable passed to the macro is named desc, the macro should consistently use _desc throughout its implementation.

How

Since this is just a typo, the only change required was adding an underscore (_)!

toorajtaraz avatar Sep 18 '24 17:09 toorajtaraz

@toorajtaraz can you please squash the commits?

brminich avatar Oct 04 '24 16:10 brminich

@toorajtaraz have you or your organization signed the CLA https://openucx.org/license/?

yosefe avatar Oct 06 '24 07:10 yosefe

@yosefe I will sign it today! Is there a way to submit it online or does it have to be mailed to the address mentioned in the CLA?

toorajtaraz avatar Oct 07 '24 15:10 toorajtaraz

@yosefe I will sign it today! Is there a way to submit it online or does it have to be mailed to the address mentioned in the CLA?

Hi, unfortunately there is no online form at this time, so kindly send it to the email address. Thank you!

yosefe avatar Oct 07 '24 15:10 yosefe

Hi, Thank you! I just emailed the signed CLA. @yosefe

toorajtaraz avatar Oct 07 '24 16:10 toorajtaraz

Hi, Thank you! I just emailed the signed CLA. @yosefe

@shamisp can you pls confirm when CLA is approved?

yosefe avatar Oct 07 '24 16:10 yosefe

@yosefe Hey,

I wanted to let you know that a few days ago my ucf consortium account was created. Thanks!

toorajtaraz avatar Oct 21 '24 18:10 toorajtaraz

approved

shamisp avatar Nov 05 '24 15:11 shamisp