TL/MLX5: fix IPv6 address conversion in inet_ntop

Open miharulidze opened this issue 1 year ago • 4 comments

What

This commit fixes the conversion of binary IPv6 address into the human-readable string using inet_ntop.

In our testing environment, the debug output of MLX5 TL prints garbage IPv6 addresses during the multicast initialization/teardown phase.

Pass sin6_addr field of type struct in6_addr that is the part of the sockaddr_in6 structure, as specified in https://man7.org/linux/man-pages/man3/inet_ntop.3.html

Feb 17 '24 09:02 miharulidze

Can one of the admins verify this patch?

Feb 17 '24 09:02 swx-jenkins3

Hi @miharulidze, thanks for the PR, do you have contributor agreement signed of?

Feb 19 '24 09:02 Sergei-Lebedev

@Sergei-Lebedev nope - but can do within the week. Should I ack you when it's done?

Feb 19 '24 11:02 miharulidze

@Sergei-Lebedev nope - but can do within the week. Should I ack you when it's done?

Yes, please. We need CLA to merge the PR.

Feb 19 '24 12:02 Sergei-Lebedev