opentype.js icon indicating copy to clipboard operation
opentype.js copied to clipboard

Published 20 hours ago • verified publisher icon opentypejs

hinting broken on the demo page

Open axkibe opened this issue 5 months ago • 4 comments

If you go to the opentype.js demo page and upload a ttf font and activate hinting it will break (see in console exports.DEBUG accessing undefined).

I guess this happened when moving opentype.js to esm things, previously in CJS world I designed it that way so the DEBUG statements get removed from minified builds. This needs to be repaired.

A PR is following in a minute.

PS: I recently noted that hinting is doing something wrong with NotoSans-Regular.ttf (as the result will look slightly "jumpy" where it should not) I will have to debug into that issue...

axkibe avatar Jan 24 '24 16:01 axkibe

revert PS: the hinter is actually fine. (I'm glad I dont have to go further down this rabbit hole again). I just had a bug in my caching mechanism for rendered glyphs with non-integer bounding boxes.

axkibe avatar Jan 25 '24 17:01 axkibe

Can you explain why you closed it, but didn't accept the PR?

axkibe avatar Feb 11 '24 18:02 axkibe

Indeed we should close this after the PR is merged

Connum avatar Feb 15 '24 11:02 Connum

Sorry, I thought you were saying that the bug was with your fork of the library and not with the main branch.

ILOVEPIE avatar Feb 26 '24 02:02 ILOVEPIE

This should be fixed now, I encountered it during development for #699. @axkibe please confirm, so we can close this

Connum avatar Apr 20 '24 23:04 Connum

Checked it again and hinting is working now.

Connum avatar Apr 21 '24 09:04 Connum