opentype.js icon indicating copy to clipboard operation
opentype.js copied to clipboard

Published 20 hours ago • verified publisher icon opentypejs

Fix keys retrieval in objectsEqual function

Open ralfstx opened this issue 1 year ago • 2 comments

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I did npm run test and all tests passed green (including code styling checks).
  • [ ] I have added tests to cover my changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the README accordingly.
  • [ ] I have read the CONTRIBUTING document.

ralfstx avatar Dec 29 '23 15:12 ralfstx

Can you please add a test for this that would have caught the issue?

Connum avatar Dec 29 '23 17:12 Connum

Can you please add a test for this that would have caught the issue?

Okay, here you go. Feel free to adjust to your conventions.

ralfstx avatar Dec 29 '23 20:12 ralfstx