opentracing.io icon indicating copy to clipboard operation
opentracing.io copied to clipboard

Semantic Conventions has broken link to the spec

Open jpkrohling opened this issue 6 years ago • 3 comments

The first link on the contents of the Semantic Conventions page has a broken link to the specification. It currently links to https://opentracing.io/specification/conventions/specification.md , but should be https://opentracing.io/specification/

image

jpkrohling avatar Oct 19 '18 10:10 jpkrohling

Yeah, that's a tricky one to fix because all of the files in the specification section are actually coming in via a submodule of the Specification repo itself. Since the files are the ones from the spec repo, all of the links are relative to that repository rather than the website. I'm not sure the best way to fix it to be honest; We could scrap the submodule and just manually update the website spec when the real spec changes, or we could try to come up with something clever.

austinlparker avatar Oct 19 '18 13:10 austinlparker

Yeah, that's a tricky one to fix

That's why I didn't open a PR right away :smile:

jpkrohling avatar Oct 19 '18 14:10 jpkrohling

There are more links in opentracing.io with similar problem that directly point to .md files in specification repo. Not sure if Hugo has some feature to handle such scenarios, where we specify how to handle a specific route for example <a> tag with specificiation.md would instead route to to /specification.

jan25 avatar Jun 08 '19 17:06 jan25