opentracing-javascript icon indicating copy to clipboard operation
opentracing-javascript copied to clipboard

Add tests to mock_tracer

Open jhorowitz opened this issue 7 years ago • 2 comments

Mock tracer has no tests which is important for something which is used to test other components.

jhorowitz avatar Nov 30 '17 17:11 jhorowitz

I'm happy to take this one.

jhorowitz avatar Nov 30 '17 17:11 jhorowitz

at minimum we should have this in unittest.js

import { MockTracer } from '../mock_tracer';

// Run the tests on the Mock Tracer.
describe('MockTracer Compatibility', () => {
    apiCompatibilityChecks(() => new MockTracer());
});

However, this currently fails because mock tracer does not implement propagation, which it does in other languages (otherwise it's not possible to use MockTracer for testing framework instrumentations).

yurishkuro avatar Nov 30 '17 20:11 yurishkuro