python-grpc icon indicating copy to clipboard operation
python-grpc copied to clipboard

Published 20 hours ago • verified publisher icon opentracing-contrib

add wrapper for grpc.Server.wait_for_termination

Open william-plano-oxb opened this issue 5 years ago • 1 comments

Hi, https://github.com/grpc/grpc/pull/19299 added a handy wait_for_termination method to the grpc.Server interface. It would be cool to implement this in _InterceptorServer and pass through to the underlying server. ... Though looking at it, I think https://github.com/opentracing-contrib/python-grpc/pull/14 will resolve this since it removes the wrapped server entirely. Is there an ETA on that PR at all?

william-plano-oxb avatar Oct 23 '19 10:10 william-plano-oxb

Hi, i agree with @william-plano-oxb getting rid of the wrapper on that interface should make things a lot better and allow for the wait_for_termination problem. Anything we can help with to get this process over the line?

inquire avatar Oct 30 '19 13:10 inquire