python-grpc
python-grpc copied to clipboard
opentracing-contrib
Ongoing maintenance of this repo
My organization has been using a forked version of grpcio-opentracing to add tracing to one of our projects and it has been great! Thanks for sharing the code, @rnburn.
However, we'd like to propose some upstream changes (namely support for grpcio >1.80.0), but it looks like this repo isn't actively maintained. I just wanted to reach out to @rnburn and @carlosalberto before opening a PR to get a better idea of who has ownership over this project. If you need help with maintenance, I'd love to help keep things up to date!
cc @austinlparker @iredelmeier - Apologies for the random tag, but it looks like you might be admins of this org?
Hey, thanks for the tag. We'd gladly accept PR's for things like adding support for newer versions of grpcio, that doesn't strike me as a problem. What other changes did you have in mind?
Hey hey @psiemens
Sorry, had been super busy the latest weeks, but we are always happy about taking PRs, as @austinlparker mentioned (I will review the pending ones this weekend).
Hey @austinlparker @carlosalberto, thanks for getting back to me! No worries about being busy -- I figured that was the case.
My changes for gRPC compatibility are very similar to the fix in https://github.com/opentracing-contrib/python-grpc/pull/17, so I hold off on opening a PR.
Before this I was experimenting with my own OpenTracing interceptor that uses the official gRPC interceptors, so I'm excited by the changes in https://github.com/opentracing-contrib/python-grpc/pull/14 (although I haven't dug too deep into the code). I'll try to find some time to do a review -- happy to help get that one merged.
Lastly, as an actionable for this issue, perhaps we could add a CONTRIBUTING.md just so there's clarity in the future. @carlosalberto, do you mind if I open a PR that lists you as the maintainer, invites others to open issues, submit PRs (and any other guidelines you'd like to include)?
Just bumped into the interceptor issue #14 fixes, and so I'm here - is this project still active? Are you looking for someone to maintain it?
