python-flask icon indicating copy to clipboard operation
python-flask copied to clipboard

Published 20 hours ago • verified publisher icon opentracing-contrib

Extended traced_attributes scope to after_request (response) too

Open lukacsg opened this issue 5 years ago • 4 comments

Traced_attributes is given and scanned in _after_request_fn too. The motivation is that this way the attributes of the response object could be presented in the trace also. Our goal is to have more control over the traced attributes because our task requires also the input and the output data in one point.

lukacsg avatar Sep 03 '19 15:09 lukacsg

Hi! Could you take a look and push this PR? This PR would be used to solve in a Seldon issue (https://github.com/SeldonIO/seldon-core/issues/719). We are waiting this to use it in production so it would be nice if it wolud be in in a next release too. @carlosalberto @yurishkuro @Jamim @jan25

Thanks!

lukacsg avatar Oct 04 '19 15:10 lukacsg

Hello @lukacsg, Could you please resolve conflicts? Thank you!

Jamim avatar Oct 19 '19 21:10 Jamim

Hello @Jamim I resolved the conflict!

Thank you for working on this PR!

lukacsg avatar Oct 21 '19 12:10 lukacsg

@Jamim @carlosalberto Hi! I really welcome that this thread is still alive. Could you push this PR to master and make a release? It is vital for us.

Thank you in advance.

lukacsg avatar Oct 22 '19 13:10 lukacsg

This package is no longer being maintained, users should migrate to the opentelemetry-api package.

Closing.

ptmcg avatar Feb 29 '24 22:02 ptmcg