python-django icon indicating copy to clipboard operation
python-django copied to clipboard

Django-REST integration?

Open ror6ax opened this issue 7 years ago • 5 comments

Would this be able to pick up DRF interactions, like Serializer -> ORM -> DB ?

ror6ax avatar Apr 05 '18 13:04 ror6ax

@tomchristie do you have any thoughts on this?

SEJeff avatar Apr 19 '18 22:04 SEJeff

@SEJeff Only that instrumenting the ORM queries really is the most important aspect.

lovelydinosaur avatar Apr 20 '18 08:04 lovelydinosaur

I would also argue that having ability to customize route -> trace tags mapping would be desirable. Anyhow, I take it you guys would consider this a valid feature?

ror6ax avatar Apr 23 '18 09:04 ror6ax

@ror6ax I just figured out how to fix the route bit I believe. I'll send some PR's soon, but it uses this class more or less like this.

It results in the route (for a DRF app that uses rest_framework.routers.DefaultRouter for the url routing that looks like this:

alert-app-service-name: /api/alert/{pk}/

Bonus points that raven-python is also licensed under the 3 clause BSD, so we could potentially lift the code if necessary to this project.

SEJeff avatar Apr 23 '18 20:04 SEJeff

Any news on this?

lovetoburnswhen avatar Apr 29 '21 18:04 lovetoburnswhen