nginx-opentracing icon indicating copy to clipboard operation
nginx-opentracing copied to clipboard

Build modules against same GLIBC as for official Nginx image

Open miry opened this issue 1 year ago • 1 comments

Extracted the problem described in https://github.com/DataDog/dd-opentracing-cpp/pull/276#issuecomment-1954260078

What we have now?

We build docker images base on official nginx images (debian or alpine): https://github.com/opentracing-contrib/nginx-opentracing/blob/ee6c78630a09bad1dc27ca2c2a6a4acb3e8a3e16/Dockerfile#L244

In same time we build bin modules for releasing using image ubuntu:2023 build/Dockerfile.

The problem that nginx images most of time would have older GLIBC version.

@dgoffredo wrote:

The latest release (v0.34.0) of nginx-opentracing is no longer compatible with nginx's debian-based docker images. nginx-opentracing v0.34.0 requires GLIBC 2.38, while e.g. nginx:1.25.4 has GLIBC 2.36:

Proposals

  • Specify the GLIBC version in binaries build to be the same as in nginx
  • Build multiple modules built against different OS: debian, ubuntu, alpine

@lucacome What will be your thoughts about this?

miry avatar Feb 20 '24 16:02 miry

Yep, this breaks usage of the binary on all Ubuntu LTS at the very least.

If the build/Dockerfile is updated to 18.04, it would link against an older more compatible glibc version at least.

whyman10x avatar Mar 05 '24 13:03 whyman10x

@lucacome Would you like tp review those changes.

miry avatar Mar 10 '24 10:03 miry