Upgrade to opentracing/0.32.0 and spring-boot 2.x

[birdli66]

Seems your contribution to the opentracing-contrib cluster lags behind what is going on else-where (opentracing, zipkin/brave), see this thread for details: https://github.com/opentracing-contrib/java-spring-cloud/issues/210#issuecomment-503031884

Do you plan to align and release 0.3.0? Thx

[geoand]

Hi @birdli66

Indeed this project is somewhat behind due to the lack of cycles at the moment... If you would like to submit a PR for the proposed updates, that would be great

[birdli66]

Had a 'quick' look, seems like at most a day's work:

• spring-boot 2.x minor changes (EnvironmentTestUtils => TestPropertyValues potentially)
• white box tests failing because brave internal structure changes (@Ignore or find another way?)
• timeouts on integration tests (did not investigate that further)
• license headers missing and outdated => license:format

Upgrading to opentracing 0.33.0 leads to issues because they clean up their API (deprecated startActive thrown out), so what is considered to be a consistent cluster is something you should have a look at knowing the cluster better.

FYI: My trial was based on these latest upgrades (i.e. latest from mavencentral, except downgrading opentracing to 0.32.0)

-    <version.io.opentracing>0.31.0</version.io.opentracing>
-    <version.io.opentracing.contrib-opentracing-spring-tracer>0.1.0</version.io.opentracing.contrib-opentracing-spring-tracer>
-    <version.org.springframework.boot>1.5.12.RELEASE</version.org.springframework.boot>
-    <version.brave-opentracing>0.31.3</version.brave-opentracing>
-    <version.zipkin-sender-okhttp>2.6.0</version.zipkin-sender-okhttp>
-    <version.zipkin>2.10.4</version.zipkin>
+    <version.io.opentracing>0.32.0</version.io.opentracing>
+    <version.io.opentracing.contrib-opentracing-spring-tracer>0.2.0</version.io.opentracing.contrib-opentracing-spring-tracer>
+    <version.org.springframework.boot>2.1.5.RELEASE</version.org.springframework.boot>
+    <version.brave-opentracing>0.33.13</version.brave-opentracing>
+    <version.zipkin-sender-okhttp>2.8.4</version.zipkin-sender-okhttp>
+    <version.zipkin>2.14.2</version.zipkin>

Let me know how

[geoand]

Had a 'quick' look, seems like at most a day's work:

• spring-boot 2.x minor changes (EnvironmentTestUtils => TestPropertyValues potentially)

Yeah should be similar to what we did with java-spring-jaeger

• white box tests failing because brave internal structure changes (@ignore or find another way?)

I would assume we should update these,

• timeouts on integration tests (did not investigate that further)

Not sure, about this, would need more investigation

• license headers missing and outdated => license:format

This one can be covered by this point.

Upgrading to opentracing 0.33.0 leads to issues because they clean up their API (deprecated startActive thrown out), so what is considered to be a consistent cluster is something you should have a look at knowing the cluster better.

FYI: My trial was based on these latest upgrades (i.e. latest from mavencentral, except downgrading opentracing to 0.32.0)

Probably best to stay with 0.32.0 that the java-spring-jager uses as well

-    <version.io.opentracing>0.31.0</version.io.opentracing>
-    <version.io.opentracing.contrib-opentracing-spring-tracer>0.1.0</version.io.opentracing.contrib-opentracing-spring-tracer>
-    <version.org.springframework.boot>1.5.12.RELEASE</version.org.springframework.boot>
-    <version.brave-opentracing>0.31.3</version.brave-opentracing>
-    <version.zipkin-sender-okhttp>2.6.0</version.zipkin-sender-okhttp>
-    <version.zipkin>2.10.4</version.zipkin>
+    <version.io.opentracing>0.32.0</version.io.opentracing>
+    <version.io.opentracing.contrib-opentracing-spring-tracer>0.2.0</version.io.opentracing.contrib-opentracing-spring-tracer>
+    <version.org.springframework.boot>2.1.5.RELEASE</version.org.springframework.boot>
+    <version.brave-opentracing>0.33.13</version.brave-opentracing>
+    <version.zipkin-sender-okhttp>2.8.4</version.zipkin-sender-okhttp>
+    <version.zipkin>2.14.2</version.zipkin>

Let me know how

[birdli66]

Thx, for the feedback, sorry for the delay, slipped my attention. Seems we are now on the sleuth/zipkin versus opentracing/jaeger train. I will come back about this.